feat: unify AST structures, introduce MIR and update codegen
This commit is contained in:
+58
-88
@@ -2,7 +2,6 @@ use std::collections::HashMap;
|
||||
|
||||
use crate::frontend::ast::*;
|
||||
use crate::frontend::token::Span;
|
||||
use crate::frontend::typed_ast::*;
|
||||
|
||||
/// A structured error produced during semantic analysis, carrying a human-readable
|
||||
/// message and the [Span] of the offending AST node for precise diagnostics.
|
||||
@@ -79,7 +78,6 @@ pub struct Sema {
|
||||
deferred_unary_neg: Vec<(Span, Ty, Ty, Option<u64>)>,
|
||||
deferred_binary: Vec<(Span, Ty)>,
|
||||
deferred_literals: Vec<(Span, Ty)>,
|
||||
is_reachable: bool,
|
||||
}
|
||||
|
||||
impl Sema {
|
||||
@@ -93,7 +91,6 @@ impl Sema {
|
||||
deferred_unary_neg: Vec::new(),
|
||||
deferred_binary: Vec::new(),
|
||||
deferred_literals: Vec::new(),
|
||||
is_reachable: true,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -245,10 +242,10 @@ impl Sema {
|
||||
match &decl.kind {
|
||||
DeclKind::Function {
|
||||
name,
|
||||
name_span,
|
||||
params,
|
||||
return_type,
|
||||
body,
|
||||
..
|
||||
} => {
|
||||
let mut typed_params = Vec::new();
|
||||
|
||||
@@ -265,24 +262,19 @@ impl Sema {
|
||||
.map(|t| Ty::from(&t.kind))
|
||||
.unwrap_or(Ty::Unit);
|
||||
|
||||
self.is_reachable = true;
|
||||
|
||||
let typed_body = self.analyze_stmt(body, &expected_ret_ty);
|
||||
|
||||
if expected_ret_ty != Ty::Unit && self.is_reachable {
|
||||
self.errors.push(SemanticError::new(
|
||||
"not all control paths return a value",
|
||||
decl.span,
|
||||
));
|
||||
}
|
||||
|
||||
self.leave_scope();
|
||||
|
||||
TypedDecl::Function {
|
||||
name: name.clone(),
|
||||
params: typed_params,
|
||||
return_type: expected_ret_ty,
|
||||
body: typed_body,
|
||||
TypedDecl {
|
||||
kind: TypedDeclKind::Function {
|
||||
name: name.clone(),
|
||||
name_span: *name_span,
|
||||
params: typed_params,
|
||||
return_type: expected_ret_ty,
|
||||
body: typed_body,
|
||||
},
|
||||
span: decl.span,
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -294,22 +286,19 @@ impl Sema {
|
||||
match &stmt.kind {
|
||||
StmtKind::Compound { inner } => {
|
||||
let mut typed_inner = Vec::new();
|
||||
let mut reported_unreachable = false;
|
||||
|
||||
self.enter_scope();
|
||||
|
||||
for s in inner {
|
||||
if !self.is_reachable && !reported_unreachable {
|
||||
self.errors
|
||||
.push(SemanticError::new("unreachable statement", s.span));
|
||||
reported_unreachable = true;
|
||||
}
|
||||
typed_inner.push(self.analyze_stmt(s, expected_ret_ty));
|
||||
}
|
||||
|
||||
self.leave_scope();
|
||||
|
||||
TypedStmt::Compound { inner: typed_inner }
|
||||
TypedStmt {
|
||||
kind: TypedStmtKind::Compound { inner: typed_inner },
|
||||
span: stmt.span,
|
||||
}
|
||||
}
|
||||
StmtKind::If {
|
||||
condition,
|
||||
@@ -322,29 +311,16 @@ impl Sema {
|
||||
self.errors.push(SemanticError::new(err, condition.span));
|
||||
}
|
||||
|
||||
let initial_reachable = self.is_reachable;
|
||||
|
||||
self.is_reachable = initial_reachable;
|
||||
let typed_then = self.analyze_stmt(then, expected_ret_ty);
|
||||
let reachable_after_then = self.is_reachable;
|
||||
let typed_elze = elze.as_ref().map(|e| self.analyze_stmt(e, expected_ret_ty));
|
||||
|
||||
let typed_elze = elze.as_ref().map(|e| {
|
||||
self.is_reachable = initial_reachable;
|
||||
self.analyze_stmt(e, expected_ret_ty)
|
||||
});
|
||||
|
||||
let reachable_after_else = if elze.is_some() {
|
||||
self.is_reachable
|
||||
} else {
|
||||
initial_reachable
|
||||
};
|
||||
|
||||
self.is_reachable = reachable_after_then || reachable_after_else;
|
||||
|
||||
TypedStmt::If {
|
||||
condition: typed_condition,
|
||||
then: Box::new(typed_then),
|
||||
elze: typed_elze.map(Box::new),
|
||||
TypedStmt {
|
||||
kind: TypedStmtKind::If {
|
||||
condition: typed_condition,
|
||||
then: Box::new(typed_then),
|
||||
elze: typed_elze.map(Box::new),
|
||||
},
|
||||
span: stmt.span,
|
||||
}
|
||||
}
|
||||
StmtKind::Return { value } => {
|
||||
@@ -355,19 +331,21 @@ impl Sema {
|
||||
self.errors.push(SemanticError::new(err, expr.span));
|
||||
}
|
||||
|
||||
self.is_reachable = false;
|
||||
|
||||
TypedStmt::Return {
|
||||
value: Some(typed_expr),
|
||||
TypedStmt {
|
||||
kind: TypedStmtKind::Return {
|
||||
value: Some(typed_expr),
|
||||
},
|
||||
span: stmt.span,
|
||||
}
|
||||
} else {
|
||||
if let Err(err) = self.unify(&Ty::Unit, expected_ret_ty) {
|
||||
self.errors.push(SemanticError::new(err, stmt.span));
|
||||
}
|
||||
|
||||
self.is_reachable = false;
|
||||
|
||||
TypedStmt::Return { value: None }
|
||||
TypedStmt {
|
||||
kind: TypedStmtKind::Return { value: None },
|
||||
span: stmt.span,
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -392,6 +370,7 @@ impl Sema {
|
||||
TypedExpr {
|
||||
kind: TypedExprKind::Identifier { name: name.clone() },
|
||||
ty,
|
||||
span: expr.span,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -402,12 +381,14 @@ impl Sema {
|
||||
TypedExpr {
|
||||
kind: TypedExprKind::Integer { value: *value },
|
||||
ty,
|
||||
span: expr.span,
|
||||
}
|
||||
}
|
||||
|
||||
ExprKind::Boolean { value } => TypedExpr {
|
||||
kind: TypedExprKind::Boolean { value: *value },
|
||||
ty: Ty::Bool,
|
||||
span: expr.span,
|
||||
},
|
||||
|
||||
ExprKind::Unary {
|
||||
@@ -435,6 +416,7 @@ impl Sema {
|
||||
expr: Box::new(typed_inner),
|
||||
},
|
||||
ty: result_ty,
|
||||
span: expr.span,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -454,6 +436,7 @@ impl Sema {
|
||||
expr: Box::new(typed_inner),
|
||||
},
|
||||
ty: Ty::Bool,
|
||||
span: expr.span,
|
||||
}
|
||||
}
|
||||
|
||||
@@ -490,6 +473,7 @@ impl Sema {
|
||||
rhs: Box::new(typed_rhs),
|
||||
},
|
||||
ty: result_ty,
|
||||
span: expr.span,
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -497,9 +481,11 @@ impl Sema {
|
||||
|
||||
/// Recursively applies the final resolved type substitutions to a typed declaration.
|
||||
fn apply_subst_decl(&self, decl: TypedDecl) -> TypedDecl {
|
||||
match decl {
|
||||
TypedDecl::Function {
|
||||
let span = decl.span;
|
||||
let kind = match decl.kind {
|
||||
TypedDeclKind::Function {
|
||||
name,
|
||||
name_span,
|
||||
params,
|
||||
return_type,
|
||||
body,
|
||||
@@ -509,45 +495,52 @@ impl Sema {
|
||||
.map(|(n, ty)| (n, self.apply_subst(&ty)))
|
||||
.collect();
|
||||
|
||||
TypedDecl::Function {
|
||||
TypedDeclKind::Function {
|
||||
name,
|
||||
name_span,
|
||||
params,
|
||||
return_type: self.apply_subst(&return_type),
|
||||
body: self.apply_subst_stmt(body),
|
||||
}
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
TypedDecl { kind, span }
|
||||
}
|
||||
|
||||
/// Recursively applies the final resolved type substitutions to a typed statement.
|
||||
fn apply_subst_stmt(&self, stmt: TypedStmt) -> TypedStmt {
|
||||
match stmt {
|
||||
TypedStmt::Compound { inner } => TypedStmt::Compound {
|
||||
let span = stmt.span;
|
||||
let kind = match stmt.kind {
|
||||
TypedStmtKind::Compound { inner } => TypedStmtKind::Compound {
|
||||
inner: inner
|
||||
.into_iter()
|
||||
.map(|s| self.apply_subst_stmt(s))
|
||||
.collect(),
|
||||
},
|
||||
|
||||
TypedStmt::If {
|
||||
TypedStmtKind::If {
|
||||
condition,
|
||||
then,
|
||||
elze,
|
||||
} => TypedStmt::If {
|
||||
} => TypedStmtKind::If {
|
||||
condition: self.apply_subst_expr(condition),
|
||||
then: Box::new(self.apply_subst_stmt(*then)),
|
||||
elze: elze.map(|s| Box::new(self.apply_subst_stmt(*s))),
|
||||
},
|
||||
|
||||
TypedStmt::Return { value } => TypedStmt::Return {
|
||||
TypedStmtKind::Return { value } => TypedStmtKind::Return {
|
||||
value: value.map(|e| self.apply_subst_expr(e)),
|
||||
},
|
||||
}
|
||||
};
|
||||
|
||||
TypedStmt { kind, span }
|
||||
}
|
||||
|
||||
/// Recursively applies the final resolved type substitutions to a typed expression.
|
||||
fn apply_subst_expr(&self, expr: TypedExpr) -> TypedExpr {
|
||||
let ty = self.apply_subst(&expr.ty);
|
||||
let span = expr.span;
|
||||
let kind = match expr.kind {
|
||||
TypedExprKind::Identifier { name } => TypedExprKind::Identifier { name },
|
||||
TypedExprKind::Integer { value } => TypedExprKind::Integer { value },
|
||||
@@ -565,7 +558,7 @@ impl Sema {
|
||||
},
|
||||
};
|
||||
|
||||
TypedExpr { kind, ty }
|
||||
TypedExpr { kind, ty, span }
|
||||
}
|
||||
|
||||
/// Resolves all deferred type constraints accumulated during analysis, such as
|
||||
@@ -682,9 +675,9 @@ impl Sema {
|
||||
#[cfg(test)]
|
||||
mod test {
|
||||
use crate::frontend::{
|
||||
ast::TypedModule,
|
||||
parser::Parser,
|
||||
sema::{Sema, SemanticError},
|
||||
typed_ast::TypedModule,
|
||||
};
|
||||
|
||||
fn analyze(source: &str) -> Result<TypedModule, Vec<SemanticError>> {
|
||||
@@ -804,27 +797,4 @@ mod test {
|
||||
let src = "fn test() { if 12 {} }";
|
||||
assert!(analyze(src).is_err());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn not_all_paths_return() {
|
||||
let src = "fn test(a: i32) -> i32 { if a < 5 { return 5; } else { } }";
|
||||
assert!(analyze(src).is_err());
|
||||
|
||||
let src = "fn test() -> i32 { }";
|
||||
assert!(analyze(src).is_err());
|
||||
|
||||
let src = "fn test(a: i32) -> i32 { if a < 5 { return 5; } return 10; }";
|
||||
assert!(analyze(src).is_ok());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn unreachable_code() {
|
||||
let src = "fn test() -> i32 { return 5; return 10; }";
|
||||
let errors = analyze(src).unwrap_err();
|
||||
assert!(
|
||||
errors
|
||||
.iter()
|
||||
.any(|e| e.message.contains("unreachable statement"))
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user